New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JaxRS-Spec] Fixes in generated pom #1035

Merged
merged 5 commits into from Sep 14, 2018

Conversation

Projects
None yet
2 participants
@jmini
Member

jmini commented Sep 14, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

Description of the PR

Several improvements in the generated POM file for the jaxrs-spec generator:

1/ Add build-helper-maven-plugin plugin in the generated pom to declare src/gen/java as sources.

=> Copied from the Jersey Jaxrs generator

The generator already output some content there:

Examples:

2/ Jackson as dependency, because the models are using those annotations.

=> Copied from the Jersey Jaxrs generator

3/ Update javax.ws.rs-api to 2.1.1 because the @PATCH annotation (already used in the generated code) is not present in the 2.0 version.

Example Line 95:

@PATCH
@Consumes({ "application/json" })
@Produces({ "application/json" })
@ApiOperation(value = "To test \"client\" model", notes = "To test \"client\" model", response = Client.class, tags={ "fake", })
@ApiResponses(value = {
@ApiResponse(code = 200, message = "successful operation", response = Client.class)
})

@wing328 wing328 added this to the 3.3.0 milestone Sep 14, 2018

@wing328

LGTM

@jmini jmini merged commit fe0f2cf into OpenAPITools:master Sep 14, 2018

4 checks passed

Shippable Run 2938 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jmini jmini changed the title from [JaxRS-Spec] Fix generated pom to [JaxRS-Spec] Fixes in generated pom Sep 14, 2018

jaumard added a commit to jaumard/openapi-generator that referenced this pull request Sep 21, 2018

[JaxRS-Spec] Fixes in generated pom (#1035)
* build-helper-maven-plugin to add src/gen/java as source folder
* update javax.ws.rs-api to 2.1.1
* add jackson as dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment