New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build changes to support jdk11+ #10717
Conversation
cc @OpenAPITools/generator-core-team |
bump @OpenAPITools/generator-core-team |
// } | ||
//} | ||
|
||
//nexusPublishing.dependsOn 'check' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I know why these are commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, good spot, basically nexusPublishing
task no longer exists, I am not sure which one should replace it. Here is the list of available publishing tasks:
closeAndReleaseSonatypeStagingRepository - Closes and releases open staging repository in 'sonatype' Nexus instance.
closeAndReleaseStagingRepository - Closes and releases open staging repositories in the following Nexus instance: 'sonatype'
closeSonatypeStagingRepository - Closes open staging repository in 'sonatype' Nexus instance.
generateMetadataFileForMavenJavaPublication - Generates the Gradle metadata file for publication 'mavenJava'.
generateMetadataFileForOpenApiGeneratorPluginMarkerMavenPublication - Generates the Gradle metadata file for publication 'openApiGeneratorPluginMarkerMaven'.
generateMetadataFileForPluginMavenPublication - Generates the Gradle metadata file for publication 'pluginMaven'.
generatePomFileForMavenJavaPublication - Generates the Maven POM file for publication 'mavenJava'.
generatePomFileForOpenApiGeneratorPluginMarkerMavenPublication - Generates the Maven POM file for publication 'openApiGeneratorPluginMarkerMaven'.
generatePomFileForPluginMavenPublication - Generates the Maven POM file for publication 'pluginMaven'.
publish - Publishes all publications produced by this project.
publishAllPublicationsToSonatypeRepository - Publishes all Maven publications produced by this project to the sonatype repository.
publishMavenJavaPublicationToMavenLocal - Publishes Maven publication 'mavenJava' to the local Maven repository.
publishMavenJavaPublicationToSonatypeRepository - Publishes Maven publication 'mavenJava' to Maven repository 'sonatype'.
publishOpenApiGeneratorPluginMarkerMavenPublicationToMavenLocal - Publishes Maven publication 'openApiGeneratorPluginMarkerMaven' to the local Maven repository.
publishOpenApiGeneratorPluginMarkerMavenPublicationToSonatypeRepository - Publishes Maven publication 'openApiGeneratorPluginMarkerMaven' to Maven repository 'sonatype'.
publishPluginMavenPublicationToMavenLocal - Publishes Maven publication 'pluginMaven' to the local Maven repository.
publishPluginMavenPublicationToSonatypeRepository - Publishes Maven publication 'pluginMaven' to Maven repository 'sonatype'.
publishToMavenLocal - Publishes all Maven publications produced by this project to the local Maven cache.
publishToSonatype - Publishes all Maven publications produced by this project to the 'sonatype' Nexus repository.
releaseSonatypeStagingRepository - Releases closed staging repository in 'sonatype' Nexus instance.
Probably publishToSonatype
, as description is most similar to pubishToNexus
:
(old description) publishToNexus - Publishes all Maven publications produced by this project to Nexus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
publishToSonatype - Publishes all Maven publications produced by this project to the 'sonatype' Nexus repository.
Yes, please use it as a replacement of nexusPublishing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's so strange, when I run gradle tasks
it finds publishToSonatype
but when I run it it crashes as task not found. publish
does the same thing, so used it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to test it over the weekend.
@wing328 dont want to rush you with checking this, but could we have these changes in 6.0 please? |
…o update-jdk Signed-off-by: agilob <info@agilob.net>
@agilob thanks again for the PR 🙏 When you've time, can you please merge the latest master into this branch? The Gradle publishing workflow has been updated by the Gradle team in the latest master 👍 |
this should start targetting java17 by now 👀 |
i can try take a look over the weekend |
@wing328 @jimschubert
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x