Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build changes to support jdk11+ #10717

Closed
wants to merge 15 commits into from
Closed

Conversation

agilob
Copy link
Contributor

@agilob agilob commented Oct 27, 2021

@wing328 @jimschubert

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@agilob agilob changed the title Semantic changes to improve java 11 compatibility Build changes to support jdk11+ Oct 28, 2021
@agilob agilob marked this pull request as ready for review October 28, 2021 09:02
@wing328
Copy link
Member

wing328 commented Oct 30, 2021

cc @OpenAPITools/generator-core-team

@agilob
Copy link
Contributor Author

agilob commented Nov 6, 2021

bump @OpenAPITools/generator-core-team

// }
//}

//nexusPublishing.dependsOn 'check'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know why these are commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, good spot, basically nexusPublishing task no longer exists, I am not sure which one should replace it. Here is the list of available publishing tasks:

closeAndReleaseSonatypeStagingRepository - Closes and releases open staging repository in 'sonatype' Nexus instance.
closeAndReleaseStagingRepository - Closes and releases open staging repositories in the following Nexus instance: 'sonatype'
closeSonatypeStagingRepository - Closes open staging repository in 'sonatype' Nexus instance.
generateMetadataFileForMavenJavaPublication - Generates the Gradle metadata file for publication 'mavenJava'.
generateMetadataFileForOpenApiGeneratorPluginMarkerMavenPublication - Generates the Gradle metadata file for publication 'openApiGeneratorPluginMarkerMaven'.
generateMetadataFileForPluginMavenPublication - Generates the Gradle metadata file for publication 'pluginMaven'.
generatePomFileForMavenJavaPublication - Generates the Maven POM file for publication 'mavenJava'.
generatePomFileForOpenApiGeneratorPluginMarkerMavenPublication - Generates the Maven POM file for publication 'openApiGeneratorPluginMarkerMaven'.
generatePomFileForPluginMavenPublication - Generates the Maven POM file for publication 'pluginMaven'.
publish - Publishes all publications produced by this project.
publishAllPublicationsToSonatypeRepository - Publishes all Maven publications produced by this project to the sonatype repository.
publishMavenJavaPublicationToMavenLocal - Publishes Maven publication 'mavenJava' to the local Maven repository.
publishMavenJavaPublicationToSonatypeRepository - Publishes Maven publication 'mavenJava' to Maven repository 'sonatype'.
publishOpenApiGeneratorPluginMarkerMavenPublicationToMavenLocal - Publishes Maven publication 'openApiGeneratorPluginMarkerMaven' to the local Maven repository.
publishOpenApiGeneratorPluginMarkerMavenPublicationToSonatypeRepository - Publishes Maven publication 'openApiGeneratorPluginMarkerMaven' to Maven repository 'sonatype'.
publishPluginMavenPublicationToMavenLocal - Publishes Maven publication 'pluginMaven' to the local Maven repository.
publishPluginMavenPublicationToSonatypeRepository - Publishes Maven publication 'pluginMaven' to Maven repository 'sonatype'.
publishToMavenLocal - Publishes all Maven publications produced by this project to the local Maven cache.
publishToSonatype - Publishes all Maven publications produced by this project to the 'sonatype' Nexus repository.
releaseSonatypeStagingRepository - Releases closed staging repository in 'sonatype' Nexus instance.

Probably publishToSonatype, as description is most similar to pubishToNexus:

(old description) publishToNexus - Publishes all Maven publications produced by this project to Nexus.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publishToSonatype - Publishes all Maven publications produced by this project to the 'sonatype' Nexus repository.

Yes, please use it as a replacement of nexusPublishing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so strange, when I run gradle tasks it finds publishToSonatype but when I run it it crashes as task not found. publish does the same thing, so used it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to test it over the weekend.

@agilob
Copy link
Contributor Author

agilob commented Nov 30, 2021

@wing328 dont want to rush you with checking this, but could we have these changes in 6.0 please?

@agilob agilob changed the base branch from master to 6.0.x February 22, 2022 15:32
…o update-jdk

Signed-off-by: agilob <info@agilob.net>
@wing328 wing328 changed the base branch from 6.0.x to master October 15, 2022 08:52
@wing328
Copy link
Member

wing328 commented May 8, 2023

@agilob thanks again for the PR 🙏

When you've time, can you please merge the latest master into this branch?

The Gradle publishing workflow has been updated by the Gradle team in the latest master 👍

@wing328 wing328 added this to the 7.0.0 milestone May 8, 2023
@agilob
Copy link
Contributor Author

agilob commented May 8, 2023

this should start targetting java17 by now 👀

@agilob
Copy link
Contributor Author

agilob commented May 8, 2023

i can try take a look over the weekend

@wing328
Copy link
Member

wing328 commented May 17, 2023

@agilob I've submitted #15553 based on this change.

Closing this one for the time being.

Please review #15553 when you've time.

@wing328 wing328 closed this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants