New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDK 9 support #1188

Merged
merged 11 commits into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@wing328
Member

wing328 commented Oct 7, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

cc @OpenAPITools/generator-core-team

wing328 added some commits Oct 7, 2018

@wing328

This comment has been minimized.

Show comment
Hide comment
@wing328

wing328 Oct 7, 2018

Member

@jimschubert I've updated the gradle version as well: https://github.com/OpenAPITools/openapi-generator/pull/1188/files#diff-100635b319e4bc29ba29da64405bcea4R57

Let me know if you want to keep the current version instead.

Member

wing328 commented Oct 7, 2018

@jimschubert I've updated the gradle version as well: https://github.com/OpenAPITools/openapi-generator/pull/1188/files#diff-100635b319e4bc29ba29da64405bcea4R57

Let me know if you want to keep the current version instead.

@wing328 wing328 added this to the 3.3.1 milestone Oct 7, 2018

@cbornet

This comment has been minimized.

Show comment
Hide comment
@cbornet

cbornet Oct 7, 2018

Member

Shouldn't we jump directly to the LTS JDK 11 ?

Member

cbornet commented Oct 7, 2018

Shouldn't we jump directly to the LTS JDK 11 ?

@wing328

This comment has been minimized.

Show comment
Hide comment
@wing328

wing328 Oct 7, 2018

Member

@cbornet yup, we can consider that.

This PR only makes the project buildable/compilable with JDK9. The compiler option is still set to 1.8 in pom.xml.

Member

wing328 commented Oct 7, 2018

@cbornet yup, we can consider that.

This PR only makes the project buildable/compilable with JDK9. The compiler option is still set to 1.8 in pom.xml.

@wing328 wing328 merged commit 56c4751 into master Oct 9, 2018

6 checks passed

Shippable Run 3400 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wing328 wing328 deleted the jdk9_support branch Oct 9, 2018

osharav pushed a commit to osharav/openapi-generator that referenced this pull request Oct 9, 2018

Add JDK 9 support (OpenAPITools#1188)
* update jmockit version

* list jvm

* test jdk9 in appveyor

* use latest version of gradle

* update to jdk9

* use openjdk9

* use default java version in appveyor

* use jdk8 docker image

* consolidate bash, ios pom into parent pom

* consolidate circlecii pom into parent pom

* remove circleci pom.xml

mwoodland added a commit to mwoodland/openapi-generator that referenced this pull request Oct 9, 2018

Add JDK 9 support (OpenAPITools#1188)
* update jmockit version

* list jvm

* test jdk9 in appveyor

* use latest version of gradle

* update to jdk9

* use openjdk9

* use default java version in appveyor

* use jdk8 docker image

* consolidate bash, ios pom into parent pom

* consolidate circlecii pom into parent pom

* remove circleci pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment