New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements #1213

Merged
merged 2 commits into from Oct 11, 2018

Conversation

Projects
None yet
1 participant
@wing328
Member

wing328 commented Oct 10, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • update contributing guideline about adding new options
  • fix the following error
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

wing328 added some commits Oct 9, 2018

@wing328 wing328 added this to the 3.3.1 milestone Oct 10, 2018

@wing328 wing328 merged commit 448680e into master Oct 11, 2018

6 checks passed

Shippable Run 3449 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

wing328 added a commit that referenced this pull request Oct 11, 2018

@wing328 wing328 deleted the minor-update1 branch Oct 11, 2018

wing328 added a commit that referenced this pull request Oct 11, 2018

@wing328

This comment has been minimized.

Show comment
Hide comment
@wing328

wing328 Oct 11, 2018

Member

Reverted the change as it's hiding all the console output.

Member

wing328 commented Oct 11, 2018

Reverted the change as it's hiding all the console output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment