New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test JDK10 in Shippable, fix javadoc issue #1335

Merged
merged 1 commit into from Oct 27, 2018

Conversation

Projects
None yet
1 participant
@wing328
Member

wing328 commented Oct 27, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • test JDK10 in Shippable
  • fix javadoc issue

@wing328 wing328 added this to the 3.3.2 milestone Oct 27, 2018

@wing328 wing328 referenced this pull request Oct 27, 2018

Closed

Fix javadoc for JDK10 #1306

4 of 4 tasks complete

@wing328 wing328 merged commit d7d5e71 into master Oct 27, 2018

6 checks passed

Shippable Run 3804 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wing328 wing328 deleted the fix_javdoc_jdk10 branch Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment