New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ensure-up-to-date script #1362

Merged
merged 5 commits into from Nov 2, 2018

Conversation

Projects
None yet
1 participant
@wing328
Member

wing328 commented Nov 2, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • Improve ensure-up-to-date script to show error messages when failing to run the script
  • fix permission issues of the scripts under the "bin" folder.

cc @OpenAPITools/generator-core-team

@wing328 wing328 added this to the 3.3.3 milestone Nov 2, 2018

@wing328 wing328 changed the title from Improve ensure-up-to-date script to [WIP] Improve ensure-up-to-date script Nov 2, 2018

wing328 added some commits Nov 2, 2018

@wing328 wing328 changed the title from [WIP] Improve ensure-up-to-date script to Improve ensure-up-to-date script Nov 2, 2018

@wing328 wing328 merged commit 36991a4 into master Nov 2, 2018

6 checks passed

Shippable Run 3893 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wing328 wing328 deleted the improve-ensure-up-to-date branch Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment