New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elm] Enable setting Http request trackers #1609

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@eriktim
Contributor

eriktim commented Dec 4, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Allow setting a tracker Maybe String for your Elm Http Requests, instead of the hardcoded Nothing.

Can you have a look, @wing328 ?

@eriktim eriktim added this to the 4.0.0 milestone Dec 4, 2018

@wing328 wing328 changed the base branch from 4.0.x to master Dec 5, 2018

@wing328

This comment has been minimized.

Member

wing328 commented Dec 5, 2018

UPDATE: changed the target branch to master as 4.0.x branch has been merged into master in preparation for the upcoming major release.

@wing328

wing328 approved these changes Dec 6, 2018

LGTM

@wing328 wing328 merged commit c0634ac into OpenAPITools:master Dec 6, 2018

4 checks passed

Shippable Run 4504 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eriktim

This comment has been minimized.

Contributor

eriktim commented Dec 6, 2018

Thanks!

@eriktim eriktim deleted the eriktim:elm-tracker branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment