New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve model class of ruby-client #1670

Merged
merged 4 commits into from Dec 15, 2018

Conversation

Projects
None yet
2 participants
@meganemura
Copy link
Contributor

meganemura commented Dec 14, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

In ruby client, we use many Model.new.build_from_hash.
This change removes redundant .new.

@meganemura meganemura force-pushed the meganemura:ruby-improve-build branch from 592a67a to d64060a Dec 14, 2018

@meganemura meganemura force-pushed the meganemura:ruby-improve-build branch from d64060a to b66ea1e Dec 14, 2018

@wing328 wing328 added this to the 4.0.0 milestone Dec 14, 2018

@wing328

This comment has been minimized.

Copy link
Member

wing328 commented Dec 14, 2018

@meganemura the PR looks good to me. I'll merge it over the weekend if no one has further question/feedback.

Have a nice weekend!

cc @cliffano (2017/07) @zlx (2017/09)

@wing328 wing328 merged commit 82fcde1 into OpenAPITools:master Dec 15, 2018

4 checks passed

Shippable Run 4642 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@meganemura meganemura deleted the meganemura:ruby-improve-build branch Dec 18, 2018

@meganemura

This comment has been minimized.

Copy link
Contributor

meganemura commented Dec 18, 2018

Thanks 😄

@wing328

This comment has been minimized.

Copy link
Member

wing328 commented Jan 2, 2019

@meganemura thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529.

Happy New Year and looking forward to more collaboration and contributions in 2019!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment