New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to use reflection in equals, hashCode (Java client) #1767

Merged
merged 6 commits into from Dec 31, 2018

Conversation

Projects
None yet
2 participants
@wing328
Copy link
Member

wing328 commented Dec 28, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • add model test template in abstract java class
  • add tests for Pet, ArrayOfArrayOfNumberOnly.java
  • add an option "useReflectionEqualsHashCode" to use org.apache.commons.lang3.builder for equals and hashCode in the models

cc @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

wing328 added some commits Dec 28, 2018

@cbornet

This comment has been minimized.

Copy link
Member

cbornet commented Dec 29, 2018

Why this option ? It looks like a bad idea to use reflection when we can just generate the equals/hashcode.

@wing328

This comment has been minimized.

Copy link
Member

wing328 commented Dec 29, 2018

Very good question. Our current approach doesn't work well with deeply nested array/map.

@wing328

This comment has been minimized.

Copy link
Member

wing328 commented Dec 30, 2018

@wing328 wing328 merged commit 2c051f2 into master Dec 31, 2018

6 checks passed

Shippable Run 4892 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wing328 wing328 deleted the java_improve_equal branch Dec 31, 2018

jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Dec 31, 2018

Merge branch 'master' into docusaurus
* master: (26 commits)
  Delete unused method (OpenAPITools#1744)
  Use JsonNullable wrapper on nullable/x-nullable fields (OpenAPITools#1762)
  Add an option to use reflection in equals, hashCode (Java client) (OpenAPITools#1767)
  [Slim] Encode path to support non-latin characters (OpenAPITools#1687)
  [elm] Add support for sending headers (OpenAPITools#1704)
  Add test case for InlineModelResolver: inline array response (OpenAPITools#1778)
  fix group parameter logic (OpenAPITools#1779)
  Add test case for InlineModelResolver: inline array request body (OpenAPITools#1777)
  Add test case for InlineModelResolver: inline array schema (OpenAPITools#1772)
  Fix type inference error (OpenAPITools#1773)
  skip default value for contaier in spring (OpenAPITools#1725)
  [Slim] Add PHP CodeSniffer config template (OpenAPITools#1764)
  Use CompareNetObject for object comparison in C# client (refactor) (OpenAPITools#1765)
  Add test case for InlineModelResolver (OpenAPITools#1771)
  Add online gen tests (OpenAPITools#1759)
  Resolve inline models before preprocess (OpenAPITools#1761)
  better handling of allOf (composition) (OpenAPITools#1757)
  Fix UUID support (OpenAPITools#1746)
  Use appInfo.version for podspec (OpenAPITools#1760)
  [Swift 4] Add `createURLRequest` method (OpenAPITools#1727)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment