New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete langs command #1836

Merged
merged 4 commits into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@ackintosh
Copy link
Member

ackintosh commented Jan 7, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Delete langs command, which is deprecated.

@ackintosh ackintosh added the WIP label Jan 7, 2019

@ackintosh ackintosh added this to the 4.0.0 milestone Jan 7, 2019

@ackintosh

This comment has been minimized.

Copy link
Member

ackintosh commented Jan 7, 2019

@ackintosh ackintosh added OpenAPI Generator CLI and removed WIP labels Jan 7, 2019

@jimschubert
Copy link
Member

jimschubert left a comment

Oops. I have the same change in my docs PR :p
I probably should've opened a smaller PR, sorry about that.

@jimschubert jimschubert merged commit 6e45567 into OpenAPITools:master Jan 7, 2019

4 checks passed

Shippable Run 5067 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ackintosh

This comment has been minimized.

Copy link
Member

ackintosh commented Jan 7, 2019

Oh sorry I didn't have notice your PR. 💦

@ackintosh ackintosh deleted the ackintosh:delete-lang-cmd branch Jan 7, 2019

jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jan 9, 2019

Merge branch 'master' into docusaurus
* master: (52 commits)
  Support for "x-enum-descriptions" (OpenAPITools#1752)
  add new sample files
  Add a checklist to issue report (OpenAPITools#1851)
  Fix typo in template (OpenAPITools#1859)
  update samples
  add isModel to updatebooleanflagwithcodegenproperty (OpenAPITools#1844)
  [python-client] Add model default values (OpenAPITools#1776)
  fix: force to decode as utf-8 when header contains application/json to avoid text garbling. (OpenAPITools#1700)
  Better support for composed schema (allOf) (OpenAPITools#1842)
  Add additional properties to Java CodegenModel (OpenAPITools#1854)
  Minor Angular type improvements (OpenAPITools#1843)
  [DART] fix: set fields to null if json value is null. (OpenAPITools#1798)
  add options to maven plugin (OpenAPITools#1845)
  fix unqiue name in handling forward slash (OpenAPITools#1839)
  better handle of oauth (OpenAPITools#1838)
  [C] Support for authentication methods (OpenAPITools#1628)
  better error message when parameter ref not defined (OpenAPITools#1837)
  Add links to articles about openapi generator
  Add a link to @watiko article
  Delete langs command (OpenAPITools#1836)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment