New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes file to 'vendor' mustache templates #1980

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@MikeRalphson
Copy link
Contributor

MikeRalphson commented Jan 25, 2019

PR checklist

  • Read the contribution guidelines.
  • n/a Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • n/a Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This has the effect of making GitHub attribute the language of the project correctly (e.g. as Java). This is useful for sites which list projects by assigned language.

Add .gitattributes file to 'vendor' mustache templates
This has the effect of making GitHub attribute the language of the project correctly (e.g. as Java). This is useful for sites which list projects by assigned language.
@@ -0,0 +1 @@
**/*.mustache linguist-vendored=true

This comment has been minimized.

@wing328

wing328 Jan 26, 2019

Member

@MikeRalphson thanks for the PR. Do you think we should add the following as well to ignore the auto-generated files?

samples/* linguist-vendored=true

@wing328 wing328 added this to the 4.0.0 milestone Feb 6, 2019

@wing328 wing328 merged commit 532743b into OpenAPITools:master Feb 6, 2019

4 checks passed

Shippable Run 5498 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment