New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP-Symfony] Catch serializer exception #2074

Merged
merged 1 commit into from Feb 10, 2019

Conversation

Projects
None yet
3 participants
@ossinkine
Copy link
Contributor

ossinkine commented Feb 6, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Since we use StrictJsonDeserializationVisitor which can throw an exception on type mismatch we should catch this exception and consider it as validation error and return "Bad request" response.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko @renepardon

@ossinkine ossinkine changed the title Catch serializer exception [PHP-Symfony] Catch serializer exception Feb 6, 2019

@ossinkine ossinkine force-pushed the ossinkine:catch-serializer-exception branch 2 times, most recently from a0b1a14 to 5e4b28e Feb 6, 2019

@ossinkine ossinkine force-pushed the ossinkine:catch-serializer-exception branch from 5e4b28e to 2ee6abf Feb 7, 2019

@ybelenko ybelenko added this to the 4.0.0 milestone Feb 7, 2019

@wing328
Copy link
Member

wing328 left a comment

LGTM

@wing328 wing328 merged commit 73d309b into OpenAPITools:master Feb 10, 2019

4 checks passed

Shippable Run 5716 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment