New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA] fix outdated windows script for test templates #2091

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@karismann
Copy link
Contributor

karismann commented Feb 7, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

the actual window script is outdated and does not fill the commited samples of java client libraries

@wing328

This comment has been minimized.

Copy link
Member

wing328 commented Feb 8, 2019

@karismann thanks for fixing it 👍

@wing328 wing328 merged commit 5281ea8 into OpenAPITools:master Feb 8, 2019

4 checks passed

Shippable Run 5737 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wing328 wing328 added this to the 4.0.0 milestone Feb 8, 2019

@karismann karismann deleted the karismann:fix-outdated-windows-script-for-test-templates branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment