Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R client refactoring #2215

merged 17 commits into from Feb 23, 2019


1 participant
Copy link

wing328 commented Feb 22, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}, ./bin/openapi3/{LANG}, ./bin/security/{LANG} and ./bin/openapi3/security/{LANG} if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

For a list of changes (breaking, non-breaking), please refer to the project:

wing328 added some commits Feb 10, 2019

[R] fix namespace, use 2-space indentation (#2105)
* fix namespace, indentation

* use 2-space indentation in model files

* update gitignore
[R] improve .travis.yml, .Rbuildignore (#2109)
* update travis

* enhance travis.yml

* update travis, .Rbuildignore
[R] Add auto-generated documentations, change parameter naming (#2114)
* add auto-generated doc for r client

* remove module name

* replace nil with void
[R] fix object serialization to JSON (#2129)
* fix object serialization

* fix array property seriziation

* fix deserializing array of string

* fix array of object deserialization
[R] Fix return type (#2140)
* fix return type

* update r petstore sample
add authenticaiton support to R (#2153)
[R] Add authentication support, minor ApiClient refactor
[R] various improvements and bug fixes (#2162)
* fix api keys in headers

* use optional parameter in function signature

* fix property naming

* fix doc assignment operator
[R] fix base64 encode (#2171)
* fix base64 encode

* fix basic http auth
[R] improve class constructor (#2208)
* update constructor with optional parameter, default value

* update r petstore sample

* clean up files

* regenerate files

@wing328 wing328 added this to In progress in R client generator refactoring via automation Feb 22, 2019

@wing328 wing328 changed the title R client refactor R client refactoring Feb 22, 2019

@wing328 wing328 merged commit e665827 into master Feb 23, 2019

6 checks passed

Shippable Run 6120 status is SUCCESS.
ci/circleci Your tests passed on CircleCI!
continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

R client generator refactoring automation moved this from In progress to Done Feb 23, 2019

@wing328 wing328 deleted the r_refactor branch Feb 23, 2019

@wing328 wing328 added this to the 4.0.0 milestone Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.