Use https URL to download dependencies #2248
Conversation
| mavenCentral(artifactUrls: ['http://maven.springframework.org/milestone']) | ||
| maven { url "http://$artifactory:8080/artifactory/repo" } | ||
| mavenCentral(artifactUrls: ['https://maven.springframework.org/milestone']) | ||
| maven { url "https://$artifactory:8080/artifactory/repo" } |
There was a problem hiding this comment.
This repository is only ever going to work in very specific user environments. Is there any value in keeping it? If it's for internal corporate artifact servers, some of them are only available over HTTP (because they are only available in a companies intra-net).
I suggest either removing it or making it so that the protocol http vs https is configurable by the user.
There was a problem hiding this comment.
Is there any value in keeping it?
I do not have an answer but I agree with you to remove these entries and only add back when there's a valid use case or reason.
| @@ -19,8 +18,6 @@ buildscript { | |||
| repositories { | |||
| mavenCentral() | |||
| mavenLocal() | |||
| mavenCentral(artifactUrls: ['https://maven.springframework.org/milestone']) | |||
There was a problem hiding this comment.
You might need this, I don't know.
| @@ -19,8 +18,6 @@ buildscript { | |||
| repositories { | |||
| mavenCentral() | |||
| mavenLocal() | |||
| mavenCentral(artifactUrls: ['https://maven.springframework.org/milestone']) | |||
There was a problem hiding this comment.
You might need this, I don't know.
There was a problem hiding this comment.
The project compiles without issue. If anyone needs this for whatever reasons, we can certainly add it back.
|
@JLLeitschuh thanks for the quick review. I'll merge this PR into master once the CI tests pass |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
cc
Kotlin tech committee: @jimschubert (2017/09), @dr4ke616 (2018/08)
Scala tech committee: @clasnake (2017/07), @jimschubert (2017/09), @shijinkui (2018/01), @ramzimaalej (2018/03)