Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Auto recreate specs in OAS3 Ruby sample #2264

Merged
merged 2 commits into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@autopp
Copy link
Contributor

autopp commented Feb 28, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

Description of the PR

In order to guarantee update of test files in sample for Ruby's OAS3 client (samples/openapi3/client/petstore/ruby/spec), bin/openapi3/ruby-client-petstore.sh will also purge the test file.

See: #2211 (comment)

@autopp autopp referenced this pull request Feb 28, 2019

Merged

Add petstore integration tests to Ruby OAS3 client #2211

0 of 4 tasks complete
@wing328
Copy link
Member

wing328 left a comment

LGTM

@wing328 wing328 added this to the 4.0.0 milestone Feb 28, 2019

@wing328 wing328 merged commit 84b99fe into OpenAPITools:master Feb 28, 2019

4 checks passed

Shippable Run 6232 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@autopp autopp deleted the autopp:auto-recreate-specs-in-oas3-ruby-sample branch Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.