Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA] Use specified data type in enum's fromValue instead of string #2347

Conversation

Projects
None yet
4 participants
@bilak
Copy link
Contributor

commented Mar 10, 2019

When working with enums, specifically on web layer, it's better to create enum with target data type instead of string.

@bilak bilak changed the title Use specified data type in enum's fromValue instead of string [JAVA] Use specified data type in enum's fromValue instead of string Mar 10, 2019

@wing328

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

@bilak please update the samples so that the CIs can test the change. Let me know if you need help on that.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

@bilak bilak force-pushed the bilak:feature/enum-fromvalue-with-datatype-instead-of-string branch from 3a47407 to d718069 Mar 12, 2019

@wing328

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

CircleCI reports the following errors:

Tests run: 199, Failures: 0, Errors: 0, Skipped: 7

[ERROR] COMPILATION ERROR : 
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/okhttp-gson/src/main/java/org/openapitools/client/model/EnumTest.java:[181,56] incompatible types: java.lang.String cannot be converted to java.lang.Integer
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/okhttp-gson/src/main/java/org/openapitools/client/model/EnumTest.java:[232,55] incompatible types: java.lang.String cannot be converted to java.lang.Double
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project petstore-okhttp-gson: Compilation failure: Compilation failure:
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/okhttp-gson/src/main/java/org/openapitools/client/model/EnumTest.java:[181,56] incompatible types: java.lang.String cannot be converted to java.lang.Integer
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/okhttp-gson/src/main/java/org/openapitools/client/model/EnumTest.java:[232,55] incompatible types: java.lang.String cannot be converted to java.lang.Double

Please take a look when you've time.

@jmini jmini added the Feature: Enum label Mar 26, 2019

@wing328

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@bilak I've resolved the issue via 66b95d9
Please take a look to see if my fix looks good to you.

@wing328

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) as the fix impacts Java generators (including Spring)

@bilak

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

I was looking at it and it seems to be ok. 👍

@wing328

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@bilak 👍 I'll merge after the shippable tests pass

@wing328 wing328 merged commit a079f70 into OpenAPITools:master Mar 27, 2019

4 checks passed

Shippable Run 6985 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jeff9finger

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

👍Great feature!

jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Apr 1, 2019

Merge branch 'master' into ihsmarkitoss-feature/cleanup
* master: (48 commits)
  [Typescript AngularJS] fix Extra package prefix in api parameters operations (OpenAPITools#2522)
  OpenAPITools#1023 - [Scala] Use status family during response processing (OpenAPITools#1024)
  Generate setters for readonly properties in server code (OpenAPITools#1582)
  [JS] fix NPE for null string and improve Travis config file (OpenAPITools#2553)
  [elm] Update ISO 8601 library (fixes missing time zone designator) (OpenAPITools#2545)
  [csharp] update sample after OpenAPITools#2528 (OpenAPITools#2550)
  [JavaScript] fix index.js, ApiClient.js and test files generated to incorrect location (OpenAPITools#2511)
  Aspnetcore nullable support (OpenAPITools#2529)
  Csharp nullable support (OpenAPITools#2528)
  [C++] [Qt5] Add enum support for client and server (OpenAPITools#2339)
  Fixed typo in migration-from-swagger-codegen.md (OpenAPITools#2548)
  [TypeScript Client] fix install Aurelia + fix use deprecated function (OpenAPITools#2514)
  [KOTLIN] fix var name not correctly sanitized (OpenAPITools#2537)
  Update swagger-parser to '2.0.11-OpenAPITools.org-1' (OpenAPITools#2262)
  Add @karismann to Java and Kotlin technical committee (OpenAPITools#2542)
  Add GoDaddy to the list of companies using OpenAPI Generator (OpenAPITools#2541)
  [Kotlin SpringBoot Server] alternative: fix optional parameter not correctly declared in service (OpenAPITools#2539)
  improve indentation, update dependencies (OpenAPITools#2521)
  update kotlin spring samples
  [JAVA] Use specified data type in enum's fromValue instead of string (OpenAPITools#2347)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.