Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename generator: csharp-refactor => csharp-netcore #2348

merged 4 commits into from Mar 12, 2019


None yet
2 participants
Copy link

wing328 commented Mar 10, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}, ./bin/openapi3/{LANG}, ./bin/security/{LANG} and ./bin/openapi3/security/{LANG} if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

As discussed, renaming the generator to csharp-netcore from csharp-refactor

cc @jimschubert

wing328 added some commits Mar 10, 2019

@wing328 wing328 referenced this pull request Mar 11, 2019


C# template refactor #737

0 of 4 tasks complete

@wing328 wing328 merged commit d2ce584 into master Mar 12, 2019

6 checks passed

Shippable Run 6467 status is SUCCESS.
ci/circleci Your tests passed on CircleCI!
continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@wing328 wing328 deleted the rename_csharp_refactor branch Mar 12, 2019

davidwcarlson added a commit to davidwcarlson/openapi-generator that referenced this pull request Mar 22, 2019

Rename generator: csharp-refactor => csharp-netcore (OpenAPITools#2348)
* renmae csharp-refactor to csharp-netcore

* update appveyor config

* update config

* update doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.