Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] url-encode path parameters #2397

Merged
merged 2 commits into from Mar 14, 2019

Conversation

Projects
None yet
1 participant
@wing328
Copy link
Member

wing328 commented Mar 14, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix issues when path parameters contain special characters that need to be url-encoded.

@auto-labeler auto-labeler bot added the Client: R label Mar 14, 2019

@auto-labeler

This comment has been minimized.

Copy link

auto-labeler bot commented Mar 14, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 4.0.0 milestone Mar 14, 2019

@wing328 wing328 added the Issue: Bug label Mar 14, 2019

@wing328 wing328 merged commit 5ba35ec into master Mar 14, 2019

6 checks passed

Shippable Run 6597 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wing328 wing328 deleted the fix_url_encoding_r branch Mar 14, 2019

davidwcarlson added a commit to davidwcarlson/openapi-generator that referenced this pull request Mar 22, 2019

[R] url-encode path parameters (OpenAPITools#2397)
* url encode path parameter

* convert number to string before encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.