[Java - OkHttp] Fix for the added interceptor and tests #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… times, which leads to a stack overflow because of too many interceptors. Also added tests for that.
4 tasks
wing328
reviewed
Mar 18, 2019
| * @return Api Client | ||
| */ | ||
| public ApiClient setHttpClient(OkHttpClient httpClient) { | ||
| this.httpClient = httpClient.newBuilder().addInterceptor(getProgressInterceptor()).build(); | ||
| public ApiClient setHttpClient(OkHttpClient newHttpClient) { |
There was a problem hiding this comment.
@burberius looks like an additional space was added to this line. Can you please remove it to make the indentation 4-space?
There was a problem hiding this comment.
Let me fix it in another PR as I want to file a PR to improve the overall indentation
There was a problem hiding this comment.
FYI. I've filed #2435 to fix the Javadoc issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Fix for the added interceptor and when the http client is set several times, which leads to a stack overflow because of too many interceptors.
Also added tests for that.
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger
PS: Security tests seem to be broken.