Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ObjC reserved words only when objcCompatible is enabled #2632

Merged
merged 4 commits into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@wing328
Copy link
Member

wing328 commented Apr 9, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #2589

cc @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @d-date (2018/03)

wing328 added some commits Apr 9, 2019

@d-date

d-date approved these changes Apr 15, 2019

Copy link
Contributor

d-date left a comment

👍

@wing328 wing328 merged commit da9ba4c into master Apr 15, 2019

6 checks passed

Shippable Run 7323 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wing328 wing328 deleted the objc_id branch Apr 15, 2019

@wing328

This comment has been minimized.

Copy link
Member Author

wing328 commented Apr 15, 2019

Upgrade Note

The following ObjC reserved words will only be included in the reserved word list when the "objcCompatible" option is enabled:

"id", "description", "NSArray", "NSURL", "CGFloat", "NSSet", "NSString", "NSInteger"
"NSUInteger", "NSError", "NSDictionary"

For example, _id will become just id for a Swift only client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.