Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Rienafairefr's templating branch updated to current master #2657
Description of the PR
master merge and Locale.ROOT fix to get #690 to cleanly merge into master.
For any discussions, please continue the thread at #690.
referenced this pull request
Apr 13, 2019
@wing328 thanks for the review. I added some clarity around those descriptions. I've also relocated package
While writing the unit test for this handlebars helper, I noticed the tests I had previously written for the mustache helpers no longer exist. Do you recall why they were removed, and if not… any objection if I add those tests back in? I looked in history and it seems they may have been removed mistakenly during a package rename.
No objection at all and I don't recall removing those tests.
We definitely welcome more tests for this project.