Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `-XX:MaxPermSize` #2712

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
2 participants
@richardwhiuk
Copy link
Contributor

commented Apr 22, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

-XX:MaxPermSize was removed and produces a warning in JDK 8.

Given OpenAPI Generator only supports Java 8 and above, and given Java 7 is EOL, we should be fine to just remove this.

Remove `-XX:MaxPermSize`
This was removed in JDK 8 and produces a warning

@wing328 wing328 added this to the 4.0.0 milestone Apr 23, 2019

@wing328

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

The CI failures have been fixed in the master

@wing328
Copy link
Member

left a comment

Thanks for the enhancement 👍

@wing328 wing328 merged commit a4be2c0 into OpenAPITools:master Apr 23, 2019

2 of 4 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Shippable Run 7421 status is SUCCESS.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@richardwhiuk richardwhiuk deleted the Metaswitch:max-perm-size branch Apr 23, 2019

jimschubert added a commit that referenced this pull request Apr 25, 2019

Merge branch 'master' into rienafairefr-templating
* master: (40 commits)
  Remove quotation marks around {{paramName}} for header params in api-body.mustache (#2727)
  Add FiNC Technologies (#2728)
  fix missing parenthesis for http bearer auth (#2723)
  Add missing closing parenthesis (#2720)
  update perl test with correct body parameter (#2717)
  [Java][Spring] Fix template for reactive implementation with `interfaceOnly` parameter (#2437)
  Bugfix(Perl): Support nested primitive types in ARRARY or HASH for basic object (#2713)
  Remove `-XX:MaxPermSize` (#2712)
  Remove setting generateAliasAsModel in rust server generator (#2714)
  update rust server samples
  Revert "update rust samples"
  update rust samples
  update samples
  [Rust Server] Improve XML support (#2504)
  Improve CONTRIBUTING.md (#2699)
  [PHP][Lumen] Rename template folder (#2707)
  [aspnetcore] Support async tasks and some code cleanups (#2629)
  [C++][Pistache] Fixed #2643 (#2653)
  update petstore samples (#2697)
  [JAVA][Webclient]fix select body for url encoded media type. (#2686)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.