Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elm petstore scripts to ensure-uptodate script #2823

Merged
merged 4 commits into from May 6, 2019

Conversation

Projects
None yet
2 participants
@wing328
Copy link
Member

commented May 5, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Update Elm petstore client samples

cc @eriktim

@wing328 wing328 added this to the 4.0.0 milestone May 5, 2019

@eriktim

This comment has been minimized.

Copy link
Contributor

commented May 5, 2019

The changes we see here are caused by not enabling elm-format post-processing. Is there a way we can run this in the ensure-up-to-date script?

@wing328

This comment has been minimized.

Copy link
Member Author

commented May 5, 2019

The changes we see here are caused by not enabling elm-format post-processing. Is there a way we can run this in the ensure-up-to-date script?

Oh right. I'll try to add it to the ensure-up-to-date script.

@wing328 wing328 changed the title Update Elm petstore client samples Add Elm petstore scripts to ensure-uptodate script May 5, 2019

@eriktim

This comment has been minimized.

Copy link
Contributor

commented May 5, 2019

Great, thanks! One last thing: I think Elm 0.18 is tested with Travis, so that one will need elm-format as well.

@wing328

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

Great, thanks! One last thing: I think Elm 0.18 is tested with Travis, so that one will need elm-format as well.

The Travis job does not run the elm shell script so I don't think we need to install elm-format in Travis (which passes: https://travis-ci.org/OpenAPITools/openapi-generator/builds/528494033?utm_source=github_status&utm_medium=notification)

@wing328 wing328 merged commit 4fa284e into master May 6, 2019

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Shippable Run 7731 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wing328 wing328 deleted the update_elm branch May 6, 2019

@wing328

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

I'd to comment out the elm script in the ensure-up-to-date file since it's causing errors (code not formatted correctly when running elm script in the CircleCI) while the tests passed before the merge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.