Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 4.0.1 snapshot #2882

Merged
merged 6 commits into from May 14, 2019

Conversation

Projects
None yet
2 participants
@wing328
Copy link
Member

commented May 13, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@wing328 wing328 added this to the 4.0.1 milestone May 13, 2019

@jmini jmini merged commit cbe39ba into master May 14, 2019

6 checks passed

Shippable Run 7926 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jmini jmini deleted the prepare_4.0.1-snapshot branch May 14, 2019

jmini added a commit that referenced this pull request May 20, 2019

@jmini

This comment has been minimized.

Copy link
Member

commented May 20, 2019

I have noticed a lot of wrong "Staging Repositories" on https://oss.sonatype.org/:

List of repositories

Repository 1170

The problem was due to the version not being updated:


This is fixed with commit:

8b34bc1


We now see a first 4.0.1-SNAPSHOT version of openapi-generator-gradle-plugin published to the sonatype-snapshots repository:
https://oss.sonatype.org/content/repositories/snapshots/org/openapitools/openapi-generator-gradle-plugin/4.0.1-SNAPSHOT/

@wing328

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

@wing328 thanks for fixing it.

@wing328

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

FYI. The file is already included in the script:

declare -a files=("modules/openapi-generator-cli/pom.xml"
                  "modules/openapi-generator-gradle-plugin/gradle.properties"
                  "modules/openapi-generator-gradle-plugin/pom.xml"
                  "modules/openapi-generator-core/pom.xml"
                  "modules/openapi-generator-maven-plugin/pom.xml"
                  "modules/openapi-generator-online/pom.xml"
                  "modules/openapi-generator/pom.xml"
                  "samples/meta-codegen/lib/pom.xml"
                  "pom.xml")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.