Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Golang][client] Allow generating go client code as a submodule #3012

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@bkabrda
Copy link
Contributor

commented May 27, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

CC @antihax @bvwells @grokify @kemokemo

This allows generating the go client package as a submodule as requested in #2940

I think the only template that needed to be fixed was go.mod.mustache, but I'll appreciate thorough review to find out if that's really correct.

Since I added this as an optional feature and turned it off by default, no files were touched by this change in the samples directory.

@bkabrda bkabrda force-pushed the bkabrda:go-client-allow-submodule branch from fb36428 to cc9caca May 27, 2019

@wing328

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

The change looks reasonable to me. If no further feedback, I'll merge it on coming Wed.

@bkabrda

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

FTR, I'm not sure why Shippable build is failing, but judging from the error, I think it's not related to this PR.

@wing328

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Restarted. All tests passed.

@wing328 wing328 merged commit 66bf0dc into OpenAPITools:master Jun 5, 2019

4 checks passed

Shippable Run 8506 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wing328

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

FYI. Filed #3104 to fix a minor issue.

jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jun 6, 2019

Merge branch 'master' into release-versioning-helper
* master:
  [Java][okhttp-gson] Update dependencies (OpenAPITools#3103)
  Link query parameter to model object (OpenAPITools#2710)
  scala-play-server: fix enum names for reserved words (OpenAPITools#3080)
  Add @Sunn to openapi generator core team (OpenAPITools#3105)
  fix NPE in go generator (OpenAPITools#3104)
  scala-play-server: fix API doc url (OpenAPITools#3096)
  [maven-plugin] fix strictSpec parameter without alias (OpenAPITools#3095)
  Ruby: Avoid double escaping path items (OpenAPITools#3093)
  [Golang][client] Allow generating go client code as a submodule. (OpenAPITools#3012)
  [CI] Test maven plugin in Travis, move jobs from Shippable to Circle CI (OpenAPITools#3087)
  general support to add scopes for bearer auth too (OpenAPITools#1984)
  feat(java-jersey2): Making response headers case-insensitive (OpenAPITools#3072)
  [KOTLIN Spring] fix generation with modelNamePrefix/Suffix (OpenAPITools#3038)
  Mark nodejs-server as deprecated (OpenAPITools#3083)
  Use 4.0.2-SNAPSHOT version in gradle samples (OpenAPITools#3085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.