Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle sample on travis #3114

merged 5 commits into from
Jun 6, 2019

Gradle sample on travis #3114

merged 5 commits into from
Jun 6, 2019


Copy link

@jimschubert jimschubert commented Jun 6, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}, ./bin/openapi3/{LANG} if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

During the 4.0.1 release, we discovered that the Maven and Gradle plugin samples weren't being effectively tested by CI. Maven has already been added to travis builds via #3087.

@jimschubert jimschubert added this to the 4.0.2 milestone Jun 6, 2019
Copy link
Member Author

jimschubert commented Jun 6, 2019

cc @wing328
./gradlew needs to be run from the plugin's directory rather than root. Do you know if wrapping a command in parentheses in Travis will report success/fail for the wrapped command?

edit: n/m I tested it with an intentionally broken commit and it does work as expected. The issue I was thinking about may only be related to maven plugins and not shell processes.

@@ -1 +1 @@
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has existed in the repository for a while, and I've had no issues building. I no longer have this version of oracle's Java, which caused builds to fail (I use jenv). I've changed this to 1.8, but we may want to remove .java-version from the repo entirely if this causes problems.

Copy link
Member Author

Shippable failure was container setup failure in downloading dependencies. Merging this since it should have no effect outside of Travis.

@jimschubert jimschubert merged commit 5de7f09 into master Jun 6, 2019
@jimschubert jimschubert deleted the gradle-sample-on-travis branch June 6, 2019 19:09
fantavlik added a commit to fantavlik/openapi-generator that referenced this pull request Jun 17, 2019
…to inline-resolver

* 'master' of (213 commits)
  Idiomatic Rust returns for Error conversions (OpenAPITools#2812)
  Add API timeout handling (OpenAPITools#3078)
  Import inner items for map (OpenAPITools#3123)
  update core team in pom.xml (OpenAPITools#3126)
  [gradle] Document consuming via gradle plugin portal (OpenAPITools#3125)
  Bump up babel-cli version to fix security alert (OpenAPITools#3121)
  [C++] [cpprestsdk] Add examples and test for cpprestsdk (OpenAPITools#3109)
  Add enum support to `rust` and skip none option serialization in clients (OpenAPITools#2244)
  Add/update new core team member: etherealjoy (OpenAPITools#3116)
  Gradle sample on travis (OpenAPITools#3114)
  [typescript-fetch] add bearer token support (OpenAPITools#3097)
  Add Q_DECLARE_METATYPE to the generated models and remove ref in signals (OpenAPITools#3091)
  [Java][okhttp-gson] Update dependencies (OpenAPITools#3103)
  Link query parameter to model object (OpenAPITools#2710)
  scala-play-server: fix enum names for reserved words (OpenAPITools#3080)
  Add @Sunn to openapi generator core team (OpenAPITools#3105)
  fix NPE in go generator (OpenAPITools#3104)
  scala-play-server: fix API doc url (OpenAPITools#3096)
  [maven-plugin] fix strictSpec parameter without alias (OpenAPITools#3095)
  Ruby: Avoid double escaping path items (OpenAPITools#3093)

# Conflicts:
#	modules/openapi-generator/src/main/java/org/openapitools/codegen/
#	modules/openapi-generator/src/test/java/org/openapitools/codegen/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant