Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go][Client] Use configured Scheme and Host in requests #3115

Merged

Conversation

Projects
None yet
2 participants
@johanbrandhorst
Copy link
Contributor

commented Jun 6, 2019

Previously we were simply setting the Host header and completely ignoring the configured scheme.

Fixes #2943

@johanbrandhorst

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

@johanbrandhorst

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

🤔 sorry, I thought you had to trigger the CI builds somehow, but they just appeared.

@johanbrandhorst

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

@wing328 looks like an unrelated error, how do you want to proceed?

@wing328 wing328 added this to the 4.0.2 milestone Jun 6, 2019

johanbrandhorst added some commits May 23, 2019

[Go][Client] Ensure test errors don't crash
Previously we did not interrupt execution of a test case
when an error was returned from an API call. This was
causing the tests to crash as soon as we try to
dereference the response.

We now fail the tests as soon as the first API error
is received.
[Go][Client] Use configured Scheme and Host in requests
Previously we were simply setting the Host header and
completely ignoring the configured scheme.

@johanbrandhorst johanbrandhorst force-pushed the johanbrandhorst:use-configured-scheme-in-request branch from 0970cd6 to eaae895 Jun 7, 2019

@johanbrandhorst

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

Fixed the test failure again 😬

@wing328

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

Looks good to me

cc @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) @kemokemo (2018/09)

@wing328 wing328 modified the milestones: 4.0.2, 4.0.3 Jun 20, 2019

@wing328 wing328 merged commit 2b55413 into OpenAPITools:master Jun 25, 2019

4 checks passed

Shippable Run 8580 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.