Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openapi-yaml] fix config option outputFile ignored by the generator #3199

Merged

Conversation

Projects
None yet
2 participants
@MichalFoksa
Copy link
Contributor

commented Jun 22, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

openapi-yaml generator ignored outputFile config option and always wrote the output to openapi/openapi.yaml file.

This PR takes outputFile into consideration and if not provided generator defaults output to openapi/openapi.yaml to preserve backwards compatibility.

Fixes #3198

MichalFoksa added some commits Jun 22, 2019

@jmini

jmini approved these changes Jun 24, 2019

Copy link
Member

left a comment

Looks good to me.

@jmini jmini added the Issue: Bug label Jun 24, 2019

@jmini jmini added this to the 4.0.3 milestone Jun 24, 2019

@jmini jmini merged commit 4ac33d8 into OpenAPITools:master Jun 24, 2019

6 checks passed

Shippable Run 8742 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jun 24, 2019

Merge branch 'master' into release-versioning-helper
* master:
  Ruby-client: Don't encode slashes if strict-spec false (OpenAPITools#3204)
  [openapi-yaml] Config option outputFile was ignored by the generator. (OpenAPITools#3199)
  Add missing javax dependencies for Java > 8 (OpenAPITools#3188)
  update kotlin samples
  Minor fix to presentation link
  Add Flow import to kotlin spring reactive (OpenAPITools#3107)
  Ktor Fix KtorExperimentalAPI import (OpenAPITools#3108)
  Add a link to the speaker deck at Kubernetes Contributor Summit (OpenAPITools#3205)
  [csharp] Adding http response details on api_docs and making example snippet compilable (OpenAPITools#3129)
  [java][jesery2]: "InjectionManagerFactory not found" issue (OpenAPITools#3153)

@wing328 wing328 changed the title [openapi-yaml] Config option outputFile was ignored by the generator. [openapi-yaml] fix config option outputFile ignored by the generator. Jul 9, 2019

@wing328 wing328 changed the title [openapi-yaml] fix config option outputFile ignored by the generator. [openapi-yaml] fix config option outputFile ignored by the generator Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.