Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] consider content in parameters and headers when computing unused schemas #3243

Merged
merged 2 commits into from Jul 4, 2019

Conversation

Projects
None yet
2 participants
@jmini
Copy link
Member

commented Jun 28, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to [build the project]
    (https://github.com/OpenAPITools/openapi-generator#14---build-projects) first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @OpenAPITools/generator-core-team

Description of the PR

Introduced with #74 and updated with #1232 and #2138, the ModelUtils.getUnusedSchemas(OpenAPI) returns all schemas that are not used in an OpenAPI specification.

This PR fixes the case where a Schema is referenced in an Content of and Header or Parameter.

Original issue: #50

@auto-labeler

This comment has been minimized.

Copy link

commented Jun 28, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328

wing328 approved these changes Jul 4, 2019

Copy link
Member

left a comment

LGTM

@wing328 wing328 merged commit 8d27857 into OpenAPITools:master Jul 4, 2019

4 checks passed

Shippable Run 8849 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wing328 wing328 added this to the 4.0.3 milestone Jul 4, 2019

@jmini jmini deleted the jmini:unused_schema_content branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.