Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart-jaguar] Makes converters publicly accessible #3245

Merged
merged 1 commit into from Jul 4, 2019

Conversation

Projects
None yet
2 participants
@athornz
Copy link
Contributor

commented Jun 28, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Makes converters publicly accessible so they can be used serialization/deserialization outside of the API client.

CC @ircecho @swipesight @jaumard

[dart-jaguar] Makes converters publicly accessible so they can be use…
…d serialization/deserlization outside of the API client
@wing328

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

The CI failure has been fixed in the master

@wing328 wing328 added this to the 4.0.3 milestone Jul 4, 2019

@wing328

wing328 approved these changes Jul 4, 2019

Copy link
Member

left a comment

LGTM

@wing328 wing328 merged commit 310f5fe into OpenAPITools:master Jul 4, 2019

3 of 4 checks passed

ci/circleci Your tests failed on CircleCI
Details
Shippable Run 8853 status is SUCCESS.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wing328 wing328 changed the title [dart-jaguar] Makes converters publicly accessible so they can be use… [dart-jaguar] Makes converters publicly accessible Jul 9, 2019

@athornz athornz referenced this pull request Jul 15, 2019

Open

[dart-jaguar] Fixes error accessing default converters #3361

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.