Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Golang][Client] Fix collectionFormat=multi request bug #3390

Conversation

@grokify
Copy link
Member

commented Jul 18, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@antihax @bvwells @kemokemo

Description of the PR

This PR fixes parameters which use collectionFormat=multi so that duplicate keys (but different values) are sent in the query string instead of a single key with a single CSV concatenated value.

See description of bug here:

#3386

Notes

This PR doesn't introduce any breaking changes and is built on the existing antihax/optional.Interface type for an optional []string.

For a breaking change, it would be nice to implement an []string in the optional structs and only use if the array has one or more elements.

For example, the following is currently generated:

type APIOpts struct {
	Name      optional.String
	UserIds   optional.Interface
}

It may be better to generate:

type APIOpts struct {
	Name      optional.String
	UserIds   []string
}
@etherealjoy

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

@wing328 wing328 added the Issue: Bug label Jul 26, 2019

@wing328 wing328 added this to the 4.1.0 milestone Jul 26, 2019

@wing328

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

@grokify thanks for the PR. Can we use tab instead of 4-space for code indentation?

@grokify

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2019

@grokify thanks for the PR. Can we use tab instead of 4-space for code indentation?

Done. Thanks for catching that.

@wing328 wing328 modified the milestones: 4.1.0, 4.1.1 Aug 9, 2019

@wing328
Copy link
Member

left a comment

Tested with collectionForamt = multi and the code compiles.

@wing328 wing328 merged commit 94d4e0c into OpenAPITools:master Aug 13, 2019

4 checks passed

Shippable Run 9406 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.