Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated netstandard, uwp support in csharp generator #4214

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@wing328
Copy link
Member

wing328 commented Oct 22, 2019

  • Deprecated netstandard, uwp support in csharp generator and suggest csharp-netcore instead
  • to close #4202

cc @mandrean (2017/08) @jimschubert (2017/09) @frankyjuang (2019/09)

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328 wing328 changed the title eprecated netstandard, uwp support in csharp Deprecated netstandard, uwp support in csharp generator Oct 22, 2019
@wing328 wing328 added this to the 4.2.0 milestone Oct 22, 2019
@wing328 wing328 merged commit 2bf708d into master Oct 23, 2019
8 checks passed
8 checks passed
Shippable Run 11454 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@wing328 wing328 deleted the csharp-wording branch Oct 23, 2019
vjauch added a commit to vjauch/openapi-generator that referenced this pull request Oct 24, 2019
amondnet added a commit to amondnet/openapi-generator that referenced this pull request Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.