[Rust Server] Handle multiple response type #4441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure response IDs are unique, even if the first sentence is identical - Handle responses where different responses produce a different type of data - Use the correct mime type for plain text and byte streams - Tidy up whitespace in client-mod.mustache
richardwhiuk
added
Client: Rust
Server: Rust
Feature: OAS 3.0 spec support
and removed
Feature: OAS 3.0 spec support
labels
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves handling of requests with multiple possible responses - especially where those responses contain different media types (e.g. JSON vs XML).
Ensure response IDs are unique, even if the first sentence of the response description is identical.
Handle responses where different responses produce a different type of data
Use the correct mime type for plain text and byte streams
Tidy up whitespace in
client-mod.mustacheThis change was contributed by @MalachiJones, with minor changes made by myself and others at @Metaswitch.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.Rust Technical Committee: @frol, @farcaller, @bjgill