Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openapi-generator executable to docker container #4610

Merged
merged 1 commit into from Nov 27, 2019

Conversation

@MartinDelille
Copy link
Contributor

MartinDelille commented Nov 26, 2019

In order to have openapi-generator in the path, I symlinked docker-entrypoint.sh.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328

@wing328

This comment has been minimized.

Copy link
Member

wing328 commented Nov 26, 2019

@wing328 wing328 added this to the 4.2.2 milestone Nov 27, 2019
@wing328 wing328 merged commit cd6986d into OpenAPITools:master Nov 27, 2019
6 checks passed
6 checks passed
Shippable Run 12516 status is SUCCESS.
Details
ci/bitrise/4a2b10a819d12b67/pr Passed - openapi-generator
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rasmusfaber added a commit to rasmusfaber/openapi-generator that referenced this pull request Nov 28, 2019
rasmusfaber added a commit to rasmusfaber/openapi-generator that referenced this pull request Nov 28, 2019
@wing328

This comment has been minimized.

Copy link
Member

wing328 commented Dec 2, 2019

@MartinDelille thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.