New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LICENSE] Update for GitHub display compatibility #467

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Projects
None yet
3 participants
@grokify
Member

grokify commented Jul 5, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Update the Apache 2.0 LICENSE file to a more standard format to support GitHub license display and GitHub license search. This format is more standard for GitHub and Apache Foundation. The file used here is the exact file GitHub provides for a new Apache 2.0 repo with the exception of updates for copyright holders.

GitHub license display:

https://blog.github.com/2016-09-21-license-now-displayed-on-repository-overview/

GitHub license search:

https://help.github.com/articles/licensing-a-repository/

github-license

This file uses the license provided by GitHub when creating a new repo with the Apache 2.0 license with changes limited to copyright year and owners. It is similar to the one Apache Foundation uses for httpd:

https://github.com/apache/httpd/blob/trunk/LICENSE

This is what this LICENSE file looks like on my fork:

screen shot 2018-07-04 at 10 59 00 pm

screen shot 2018-07-04 at 10 58 45 pm

@grokify grokify changed the title from Update LICENSE for GitHub display compatibility to [LICENSE] Update for GitHub display compatibility Jul 5, 2018

@wing328 wing328 added this to the 3.1.0 milestone Jul 5, 2018

@jmini

jmini approved these changes Jul 5, 2018

@jmini jmini merged commit 60da6fb into OpenAPITools:master Jul 5, 2018

3 of 4 checks passed

Shippable Run 1231 status is WAITING.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jul 7, 2018

Merge branch 'master' into generator-validation-option
* master: (116 commits)
  3.1.0 release (OpenAPITools#486)
  Fix broken link to openapi generator plugin README (OpenAPITools#484)
  show warning message for nodejs server only (OpenAPITools#481)
  Add grokify to Go technical committee (OpenAPITools#479)
  [Slim] Improve codebase decouple (OpenAPITools#438)
  Ensure typescript samples are up to date (OpenAPITools#444)
  Update README.md
  [Golang][client] delete sample output dir before rebuild (OpenAPITools#477)
  update petstore samples (OpenAPITools#478)
  Revert "Improve Docker Tags (OpenAPITools#390)"
  update go client test dependencies (OpenAPITools#468)
  [Golang][client] fix for schema definition name `file` (OpenAPITools#433)
  Fix '.travis' file (syntax)
  make LICENSE GitHub display compatible (OpenAPITools#467)
  Improve Docker Tags (OpenAPITools#390)
  [Golang][client] fix file suffix for _test.go (OpenAPITools#449)
  Remove copy section (OpenAPITools#463)
  Add link to presentation (OpenAPITools#465)
  Use postProcessOperationsWithModels(Map, List) (OpenAPITools#431)
  [C] Adding petstore sample written in C (OpenAPITools#306)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment