Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce scope of recommended git configuration #4983

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@valery1707
Copy link
Contributor

valery1707 commented Jan 12, 2020

Current scope (--global) of recommendation for this project can affect all others projects on user's machine.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@valery1707 valery1707 force-pushed the valery1707:patch-1 branch from 0a3780b to 2202330 Jan 12, 2020
Copy link
Member

wing328 left a comment

Looks reasonable to me.

@wing328 wing328 merged commit b22f7f0 into OpenAPITools:master Jan 13, 2020
5 of 6 checks passed
5 of 6 checks passed
ci/bitrise/4a2b10a819d12b67/pr Failed - openapi-generator
Details
Shippable Run 13577 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wing328 wing328 added this to the 4.2.3 milestone Jan 13, 2020
@valery1707 valery1707 deleted the valery1707:patch-1 branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.