Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluating https issues in CircleCI (on top of CiscoM31-maven-https #5034

Merged
merged 5 commits into from Jan 18, 2020

Conversation

jimschubert
Copy link
Member

@jimschubert jimschubert commented Jan 18, 2020

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert jimschubert merged commit ea55968 into master Jan 18, 2020
8 of 10 checks passed
@jimschubert jimschubert deleted the CiscoM31-maven-https branch Jan 18, 2020
@jimschubert
Copy link
Member Author

@jimschubert jimschubert commented Jan 19, 2020

@sebastien-rosset circleci looks good now. Thanks for working to get that fixed!

jimschubert added a commit that referenced this issue Jan 19, 2020
* master:
  Evaluating https issues in CircleCI (on top of CiscoM31-maven-h… (#5034)
jimschubert added a commit to jimschubert/openapi-generator that referenced this issue Jan 19, 2020
This continues on work in OpenAPITools#5033 and OpenAPITools#5034 which convert all http usage
to https to unblock CircleCI builds.

In OpenAPITools#5034, mavenCentral() DSL was updated to explicitly target the https
maven repo because Gradle didn't force TLS 1.2 until v4.8.1 and many of
our examples use earlier versions of Gradle.  The Kotlin meta generator
was missed because it is a .kts build file rather than build.gradle, and
the mustache filename doesn't have kts in it; the file was updated as if
it was build.gradle (groovy syntax).
jimschubert added a commit that referenced this issue Jan 19, 2020
This continues on work in #5033 and #5034 which convert all http usage
to https to unblock CircleCI builds.

In #5034, mavenCentral() DSL was updated to explicitly target the https
maven repo because Gradle didn't force TLS 1.2 until v4.8.1 and many of
our examples use earlier versions of Gradle.  The Kotlin meta generator
was missed because it is a .kts build file rather than build.gradle, and
the mustache filename doesn't have kts in it; the file was updated as if
it was build.gradle (groovy syntax).
jimschubert added a commit to jimschubert/openapi-generator that referenced this issue Jan 31, 2020
* 4.3.x: (82 commits)
  [java][client] oneOf support for jackson clients (OpenAPITools#5120)
  [dart-dio] Various fixes (OpenAPITools#5027)
  Add java code comments based on explanation from Jim Schubert (OpenAPITools#5048)
  Execute ./bin/openapi3/go-experimental-petstore.sh script (OpenAPITools#5049)
  [docs] Sorted doc outputs and clean up duplicated CliOptions (OpenAPITools#5046)
  Add docs/installation.md and docsite index to version update script (OpenAPITools#5037)
  [gradle] consistent use of maven url in gradle files (OpenAPITools#5045)
  Use HTTPS Maven URL in Kotlin meta generator (OpenAPITools#5043)
  [Python] fix numeric enum in python flask, aiohttp (OpenAPITools#5019)
  add multipleOf to various codegen classes (OpenAPITools#5021)
  Add a link to a youtube video on Pulp and OpenAPI Generator (OpenAPITools#5038)
  Evaluating https issues in CircleCI (on top of CiscoM31-maven-h… (OpenAPITools#5034)
  better code format in java jersey doc (OpenAPITools#5031)
  Escape query params before invoking api (OpenAPITools#5023)
  [Java][jersey2] Use builder pattern for requests (OpenAPITools#4666)
  [Slim4] Add integer formats support to Data Mocker (OpenAPITools#4965)
  Add a link to Scala Gatling blog post (OpenAPITools#5029)
  minor improve to rust server (OpenAPITools#5020)
  [Rust Server] fix handling of special characters in path param names (OpenAPITools#4897)
  [dart-dio] Fixes issues with DateTime import and form date paramaterToString function (OpenAPITools#4929)
  ...
@wing328 wing328 added this to the 4.2.3 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants