Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp-netcore] Remove unnecessary legacy project definitions #5108

Merged
merged 10 commits into from Feb 1, 2020

Conversation

@shibayan
Copy link
Contributor

shibayan commented Jan 25, 2020

PR Details

  • SDK-based projects implicitly reference the default assembly
  • Remove unnecessary NuGet package definitions from test projects

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@mandrean @jimschubert @frankyjuang

@wing328

This comment has been minimized.

Copy link
Member

wing328 commented Jan 29, 2020

Thanks for the PR. I would recommend filing a separate PR (target 5.0.x branch) for the following changes instead as these are breaking changes without fallbacks.

  • project.json is very old project format and no longer used
  • packages.config is not required for SDK based projects
@shibayan

This comment has been minimized.

Copy link
Contributor Author

shibayan commented Jan 29, 2020

@wing328 Thank you for feedback. The removal of project.json and package.config will be handled separately by Pull Request.

shibayan added 2 commits Jan 29, 2020
This reverts commit cc0bd07.
@shibayan shibayan changed the title [csharp-netcore] Remove unnecessary legacy files and definitions [csharp-netcore] Remove unnecessary legacy project definitions Jan 29, 2020
@shibayan

This comment has been minimized.

Copy link
Contributor Author

shibayan commented Jan 29, 2020

OpenAPIClientCore/src/Org.OpenAPITools/project.json was deleted because it was no longer generated automatically.

@wing328
wing328 approved these changes Feb 1, 2020
Copy link
Member

wing328 left a comment

Tested locally and the project built without issue.

@wing328 wing328 merged commit a8435d1 into OpenAPITools:master Feb 1, 2020
6 checks passed
6 checks passed
Shippable Run 14354 status is SUCCESS.
Details
ci/bitrise/4a2b10a819d12b67/pr Passed - openapi-generator
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shibayan shibayan deleted the shibayan:optimize-netcore branch Feb 2, 2020
@wing328 wing328 added this to the 4.3.0 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.