Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing keywords in rust #5244

Merged
merged 1 commit into from Feb 13, 2020
Merged

Add missing keywords in rust #5244

merged 1 commit into from Feb 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 8, 2020

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ghost
Copy link
Author

ghost commented Feb 8, 2020

@ghost
Copy link
Author

ghost commented Feb 8, 2020

@frol (2017/07) @farcaller (2017/08) @bjgill (2017/12) @richardwhiuk (2019/07)

@ghost ghost requested a review from wing328 February 8, 2020 10:32
@bcourtine
Copy link
Contributor

bcourtine commented Feb 11, 2020

Hi @arun-nalla.

You forgot to regenerate and commit documentation update (docs/generators/rust.md file), to reflect keyword update in documentation. This documentation/code mismatch is the cause for current CI failure.

Except that, it looks good!

@wing328
Copy link
Member

wing328 commented Feb 13, 2020

@arun-nalla thanks for the review. I'll do it after merging this PR into master.

@wing328 wing328 merged commit 466bacb into OpenAPITools:master Feb 13, 2020
MikailBag pushed a commit to MikailBag/openapi-generator that referenced this pull request Mar 23, 2020
@wing328 wing328 added this to the 4.3.0 milestone Mar 26, 2020
@wing328
Copy link
Member

wing328 commented Mar 27, 2020

@arun-nalla thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952

@ghost ghost deleted the patch-1 branch May 15, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants