Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scala version in parent pom #5647

Merged
merged 2 commits into from Mar 24, 2020
Merged

Remove scala version in parent pom #5647

merged 2 commits into from Mar 24, 2020

Conversation

@wing328
Copy link
Member

wing328 commented Mar 20, 2020

Remove scala version in parent pom as seems like it's not used in the project.

Related: #5618

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03)

@wing328 wing328 added this to the 4.3.0 milestone Mar 23, 2020
@jimschubert jimschubert merged commit 6bf432a into master Mar 24, 2020
10 checks passed
10 checks passed
Shippable Run 15891 status is SUCCESS.
Details
ci/bitrise/4a2b10a819d12b67/pr Passed - openapi-generator
Details
ci/bitrise/4a2b10a819d12b67/push Passed - openapi-generator
Details
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jimschubert jimschubert deleted the scala_version_remove branch Mar 24, 2020
@jimschubert

This comment has been minimized.

Copy link
Member

jimschubert commented Mar 24, 2020

Thanks for cleaning that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.