Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra modules to main dockerfile #650

Merged
merged 1 commit into from Jul 28, 2018

Conversation

Projects
None yet
2 participants
@bjgill
Copy link
Contributor

bjgill commented Jul 25, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.2.x, 4.0.x. Default: master.
    - [ ] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix for #648.

Pulls in additional modules so that the mvn package is successful.

This does give us a ~400 MB container, though. I think we could shrink it back down somewhat by deleting all the mvn outputs save for swagger-codegen-cli.jar. I'm not entirely sure what the purpose of this docker container is, though, so am not sure whether that would be acceptable.

Benjamin Gill
Add extra modules to main dockerfile
So that the mvn build is successful

@wing328 wing328 added this to the 3.2.0 milestone Jul 28, 2018

@wing328
Copy link
Member

wing328 left a comment

Tested locally and the fix is good.

@wing328 wing328 merged commit 3c3ac0a into OpenAPITools:master Jul 28, 2018

4 checks passed

Shippable Run 1742 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bjgill bjgill deleted the Metaswitch:working-dockerfile branch Jul 28, 2018

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.