Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5 server] Improve qt5 server naming #655

Merged
merged 3 commits into from Jul 26, 2018

Conversation

etherealjoy
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • Rename folders, files and scripts to indicate framework being used
  • Add beta info to the description

@etherealjoy
Copy link
Contributor Author

@wing328
I reworked the names according to @stkrwork request to have class and filenames indicative of Frameworks.
Also added beta tags and windows script

@wing328 wing328 merged commit 534b6b5 into OpenAPITools:master Jul 26, 2018
@wing328 wing328 added this to the 3.2.0 milestone Jul 26, 2018
@wing328 wing328 changed the title [cpp qt5 server] Improve qt5 server naming qt5 server] Improve qt5 server naming Aug 6, 2018
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Adapted according to reviews

* Add changed files

* Update beta tag to the naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants