Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string comparison in fsharp generator tests #7052

Merged
merged 1 commit into from Jul 27, 2020
Merged

Fix string comparison in fsharp generator tests #7052

merged 1 commit into from Jul 27, 2020

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jul 26, 2020

Fix string comparison in fsharp generator tests by using .equals()

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

FYI @nmfisher

@wing328 wing328 added this to the 5.0.0 milestone Jul 26, 2020
@wing328 wing328 merged commit 2743242 into master Jul 27, 2020
@wing328 wing328 deleted the fsharp-fix branch July 27, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant