Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Fixes hub dockerfile for online project #914

Merged
merged 1 commit into from Aug 28, 2018

Conversation

Projects
None yet
3 participants
@jimschubert
Copy link
Member

jimschubert commented Aug 28, 2018

An update was made in #876 to remove version from the generated artifact
for openapi-generator-online. The change is missing the -online suffix.
My original glob pattern put the * in the wrong place for
maintainability.

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
[docker] Fixes hub dockerfile for online project
An update was made in #876 to remove version from the generated artifact
for openapi-generator-online. The change is missing the -online suffix.
My original glob pattern put the * in the wrong place for
maintainability.

@jimschubert jimschubert requested a review from jmini Aug 28, 2018

@jimschubert jimschubert added the Docker label Aug 28, 2018

@jmini

jmini approved these changes Aug 28, 2018

@jimschubert

This comment has been minimized.

Copy link
Member Author

jimschubert commented Aug 28, 2018

Thanks for reviewing!

@jimschubert jimschubert merged commit 2544ace into master Aug 28, 2018

6 checks passed

Shippable Run 2566 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jimschubert jimschubert deleted the fix-hub-online-dockerfile branch Aug 28, 2018

@jimschubert

This comment has been minimized.

Copy link
Member Author

jimschubert commented Aug 30, 2018

Master builds appear to be working as expected (see https://hub.docker.com/r/openapitools/openapi-generator/builds/).

@jmini @wing328 I haven't merged anything into the 3.3.x and 4.0.x branches to test those, because I wasn't sure how their merges are being handled. I'd propose after next week's revision release, we look at how we might consolidate https://hub.docker.com/r/openapitools/openapi-generator-cli/ and https://hub.docker.com/r/openapitools/openapi-generator-online/ (even if it's potentially triggering a build based on the openapi-generator image's build).

@wing328 wing328 added this to the 3.2.3 milestone Aug 30, 2018

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019

[docker] Fixes hub dockerfile for online project (OpenAPITools#914)
An update was made in OpenAPITools#876 to remove version from the generated artifact
for openapi-generator-online. The change is missing the -online suffix.
My original glob pattern put the * in the wrong place for
maintainability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.