New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "ensure-up-to-date" execution to CircleCI #944

Merged
merged 3 commits into from Aug 31, 2018

Conversation

Projects
None yet
2 participants
@jmini
Member

jmini commented Aug 31, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Extracted from PR #929:
@wing328 proposed to move execution of ensure-up-to-date (see #80) to CircleCI.

This PR does the change and I will perform some checks to ensure that it works as expected.

@jmini

This comment has been minimized.

Show comment
Hide comment
@jmini

jmini Aug 31, 2018

Member

Commit df18063 added to see if ensure-up-to-date is working. CircleCI should be red.

Member

jmini commented Aug 31, 2018

Commit df18063 added to see if ensure-up-to-date is working. CircleCI should be red.

Remove mvn command and update "samples/"
* bin/java-petstore-rest-assured.sh to update "samples/"
@jmini

This comment has been minimized.

Show comment
Hide comment
@jmini

jmini Aug 31, 2018

Member

Error as expected:

circleci

Important: you need to switch to the second tab #queue-placeholder/containers/2 in the URL to see the error.

Member

jmini commented Aug 31, 2018

Error as expected:

circleci

Important: you need to switch to the second tab #queue-placeholder/containers/2 in the URL to see the error.

@jmini jmini merged commit f95dfbe into OpenAPITools:master Aug 31, 2018

4 checks passed

Shippable Run 2656 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wing328 wing328 added this to the 3.3.0 milestone Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment