New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore modules/openapi-generator-gradle-plugin/bin/ #983

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
3 participants
@ndbroadbent
Contributor

ndbroadbent commented Sep 6, 2018

I'm always seeing this in git status after compiling the project:

untracked: modules/openapi-generator-gradle-plugin/bin/

I imagine that these are build artifacts that shouldn't be checked in, so I've added it to .gitignore.

@wing328

This comment has been minimized.

Show comment
Hide comment
@wing328

wing328 Sep 6, 2018

Member

I just clone the project into a tmp directory and run mvn clean install but I couldn't repeat what you posted above:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] openapi-generator-project 3.3.0-SNAPSHOT ........... SUCCESS [ 14.484 s]
[INFO] openapi-generator (core library) ................... SUCCESS [01:18 min]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 40.590 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [ 12.334 s]
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... SUCCESS [ 49.396 s]
[INFO] openapi-generator-online 3.3.0-SNAPSHOT ............ SUCCESS [ 22.180 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:41 min
[INFO] Finished at: 2018-09-06T18:30:44+08:00
[INFO] ------------------------------------------------------------------------
➜  openapi-generator git:(master) git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
➜  openapi-generator git:(master)
Member

wing328 commented Sep 6, 2018

I just clone the project into a tmp directory and run mvn clean install but I couldn't repeat what you posted above:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] openapi-generator-project 3.3.0-SNAPSHOT ........... SUCCESS [ 14.484 s]
[INFO] openapi-generator (core library) ................... SUCCESS [01:18 min]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 40.590 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [ 12.334 s]
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... SUCCESS [ 49.396 s]
[INFO] openapi-generator-online 3.3.0-SNAPSHOT ............ SUCCESS [ 22.180 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:41 min
[INFO] Finished at: 2018-09-06T18:30:44+08:00
[INFO] ------------------------------------------------------------------------
➜  openapi-generator git:(master) git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
➜  openapi-generator git:(master)
@ndbroadbent

This comment has been minimized.

Show comment
Hide comment
@ndbroadbent

ndbroadbent Sep 6, 2018

Contributor

Hmm I'm still seeing this when I run mvn install, maybe it's my version of Java or one of the tools I'm using.

Contributor

ndbroadbent commented Sep 6, 2018

Hmm I'm still seeing this when I run mvn install, maybe it's my version of Java or one of the tools I'm using.

@jmini

jmini approved these changes Sep 6, 2018

Ok to add this in my opinion

@wing328

This comment has been minimized.

Show comment
Hide comment
@wing328

wing328 Sep 7, 2018

Member

Ok. I agree it may have to do with machine setup. Let's merge this to keep more users happy with contributing back to OpenAPI Generator.

Member

wing328 commented Sep 7, 2018

Ok. I agree it may have to do with machine setup. Let's merge this to keep more users happy with contributing back to OpenAPI Generator.

@wing328 wing328 merged commit a0f8c5e into OpenAPITools:master Sep 7, 2018

4 checks passed

Shippable Run 2776 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ndbroadbent

This comment has been minimized.

Show comment
Hide comment
@ndbroadbent

ndbroadbent Sep 7, 2018

Contributor
Contributor

ndbroadbent commented Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment