New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compiling against globally installed libphysfs #382

Open
pkubaj opened this Issue Jul 13, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@pkubaj
Contributor

pkubaj commented Jul 13, 2018

I'm porting OpenApoc to FreeBSD. It compiles fine, but installs its own copy of libphysfs, which will conflict with physfs installed from repository. Would it be possible to use the already installed libphysfs?

@JonnyH

This comment has been minimized.

Show comment
Hide comment
@JonnyH

JonnyH Jul 13, 2018

Collaborator

The physfs we use is modified slightly to standardise the case (it by default used UPPERCASE while (at least) linux's iso mount did lowercase, so it would require us to handle both if we wanted people to be able to use 'real' CDs).

Plus the iso support in physfs was completely broken when we started using it, so it required some patches. I /think/ upstream now has all this fixed up now, but it gives you context.

Collaborator

JonnyH commented Jul 13, 2018

The physfs we use is modified slightly to standardise the case (it by default used UPPERCASE while (at least) linux's iso mount did lowercase, so it would require us to handle both if we wanted people to be able to use 'real' CDs).

Plus the iso support in physfs was completely broken when we started using it, so it required some patches. I /think/ upstream now has all this fixed up now, but it gives you context.

@pkubaj

This comment has been minimized.

Show comment
Hide comment
@pkubaj

pkubaj Jul 17, 2018

Contributor

Could you then add non-default CMake setting not to use local physfs?

Contributor

pkubaj commented Jul 17, 2018

Could you then add non-default CMake setting not to use local physfs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment