New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash after try to buy equipment for vehicles & ships #389

Closed
Maddead opened this Issue Sep 16, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@Maddead

Maddead commented Sep 16, 2018

OpenApoc-v0.1-245-gb4416b1e

For the first time in 1st day buing equipment for vehicles and sell vehicles going normally, but fo the second time the game is crashes when I clicked icon "equipment for aircrafts" in buy menu.

"No aequipment type matching ID "VEHICLE_794" and I try to click limp along "No aequipment type matching ID "VEHICLE_794 found"
bug 1
bug 2

Problem signature:
Problem Event Name: APPCRASH
Application Name: OpenApoc.exe
Application Version: 0.0.0.0
Application Timestamp: 5b919c27
Fault Module Name: OpenApoc.exe
Fault Module Version: 0.0.0.0
Fault Module Timestamp: 5b919c27
Exception Code: c0000005
Exception Offset: 002a522a
OS Version: 6.1.7601.2.1.0.256.1
Locale ID: 1049
Additional Information 1: 0a9e
Additional Information 2: 0a9e372d3b4ad19135b953a78882e789
Additional Information 3: 0a9e
Additional Information 4: 0a9e372d3b4ad19135b953a78882e789

@FilmBoy84

This comment has been minimized.

Show comment
Hide comment
@FilmBoy84

FilmBoy84 Sep 16, 2018

Contributor

Thanks for the report, this is further confirmation that the bug reported in issue #260 is still present

I believe @redv and @JonnyH were looking into it, but the code is a mess and likely needs a complete refactoring

Workarounds are listed on issue #260 accordingly, but in effect it means not selling anything or hiring/firing staff

It's a monumentally frustrating bug that has largely stopped me testing the game until it's fixed

@makus82 do you have any skills that may assist in fixing it?

Contributor

FilmBoy84 commented Sep 16, 2018

Thanks for the report, this is further confirmation that the bug reported in issue #260 is still present

I believe @redv and @JonnyH were looking into it, but the code is a mess and likely needs a complete refactoring

Workarounds are listed on issue #260 accordingly, but in effect it means not selling anything or hiring/firing staff

It's a monumentally frustrating bug that has largely stopped me testing the game until it's fixed

@makus82 do you have any skills that may assist in fixing it?

@makus82

This comment has been minimized.

Show comment
Hide comment
@makus82

makus82 Sep 16, 2018

Contributor

great report =] @Maddead

Contributor

makus82 commented Sep 16, 2018

great report =] @Maddead

Jarskih added a commit to Jarskih/OpenApoc that referenced this issue Oct 10, 2018

Fix to OpenApoc#389 & OpenApoc#260
When selling vehicles the switch was not exited and caused bugs related
to agent equipment.

JonnyH added a commit that referenced this issue Oct 10, 2018

@Jarskih

This comment has been minimized.

Show comment
Hide comment
@Jarskih

Jarskih Oct 12, 2018

Contributor

@FilmBoy84 and @JonnyH this should be fixed.

Contributor

Jarskih commented Oct 12, 2018

@FilmBoy84 and @JonnyH this should be fixed.

@FilmBoy84

This comment has been minimized.

Show comment
Hide comment
@FilmBoy84

FilmBoy84 Oct 12, 2018

Contributor

Testing on OpenApoc-x64-v0.1-251-g8cd7a0db confirms this as fixed
Great work Jarskih <3 and JonnyH for merging so quickly
Closing it now

Contributor

FilmBoy84 commented Oct 12, 2018

Testing on OpenApoc-x64-v0.1-251-g8cd7a0db confirms this as fixed
Great work Jarskih <3 and JonnyH for merging so quickly
Closing it now

@FilmBoy84 FilmBoy84 closed this Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment