New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting abstract classes without virtual destructors is undefined #1

Merged
merged 1 commit into from Jul 18, 2014

Conversation

Projects
None yet
2 participants
@JonnyH
Collaborator

JonnyH commented Jul 17, 2014

Deleting abstract classes without virtual destructor is undefined, according to gcc warnings.

Fix this by having a trivial virtual destructor defined for Stage and Shader classes.

@pmprog

This comment has been minimized.

Show comment
Hide comment
@pmprog

pmprog Jul 18, 2014

Collaborator

I've never heard of that, but urm yeah, okay :)

Collaborator

pmprog commented Jul 18, 2014

I've never heard of that, but urm yeah, okay :)

pmprog added a commit that referenced this pull request Jul 18, 2014

Merge pull request #1 from JonnyH/fix-virtual-destructors
Deleting abstract classes without virtual destructors is undefined

@pmprog pmprog merged commit 735d258 into OpenApoc:master Jul 18, 2014

@JonnyH JonnyH deleted the JonnyH:fix-virtual-destructors branch Jan 24, 2015

Istrebitel added a commit that referenced this pull request Oct 4, 2016

Istrebitel added a commit that referenced this pull request Oct 10, 2016

Istrebitel added a commit that referenced this pull request Oct 19, 2016

Istrebitel added a commit that referenced this pull request Oct 22, 2016

Istrebitel added a commit that referenced this pull request Nov 26, 2016

los block pathfinding progress #1
- algorithm up and running (need debug and further testing, as well as
improvements of unoptimal paths)

Istrebitel added a commit that referenced this pull request Mar 18, 2017

AI framework and implementation progress #1
- AI framework ready
- AI patrolling, attacking with weapons (simple), managing inventory

Istrebitel added a commit that referenced this pull request Mar 18, 2017

Fire Progress #1
- first implementation of fire spread
- fire now behaves properly (starts small, goes big, then dies out)
- map parts catch on fire and burn out, get destroyed
- fixed ai bug (tactical trying to order dead units around)

Istrebitel added a commit that referenced this pull request Mar 18, 2017

Istrebitel added a commit that referenced this pull request Mar 18, 2017

Psi Progress #1, Default AI fix
- Progress on psionics
- Units now autoattack enemies seen by someone else (as per Vanilla
behavior)
- Fixed bug: AI would try to attack nearest unit even if it's down

Istrebitel added a commit that referenced this pull request Mar 18, 2017

Istrebitel added a commit that referenced this pull request Mar 18, 2017

Istrebitel added a commit that referenced this pull request Mar 18, 2017

Strafing Progress #1, fixed bug with moving/aiming
- Working towards strafing movement
- Fixed bug with unit trying to change stance while moving and aiming

Istrebitel added a commit that referenced this pull request Mar 18, 2017

Brainsuckers Stage #1, Jumping off ledges
- Implemented "j" hotkey from vanilla, soldier jumping down a level off
a ledge
- Brought falling units handling in tune with falling items
- Implemented brainsuckers properly (need further testing, but seems to
work)

Istrebitel added a commit that referenced this pull request Apr 4, 2017

Turn Based Progress #1
- TB UI for when it's our turn
- TB UI for when it's not our turn
- TB cost to fire
- AI properly interacting with AI
- Interrupt properly working
- TU Reserving

Istrebitel added a commit that referenced this pull request Apr 7, 2017

Events in Battlescape, Morale, Score Progress #1
- Implemented event ticker, event tracking for battlescape
- Implemented moving to event in battlescape
- Implemented GameEvents for classes Agent and Battle
- Fixed some bugs with events
- Morale for damage and kills
- Implementing score

Istrebitel added a commit that referenced this pull request Apr 24, 2017

Istrebitel added a commit that referenced this pull request Apr 24, 2017

Item recharge, Skirmish Progress #1
- Implementing forms to launch battlescape skirmish (progress)
- Fixed unit AI running before battle start (potentially psi-attacking
before player can do anything etc.)
- Fixed shield update to match vanilla (only one is restored, 1/sec or
11/turn)
- Fixed item recharge to work in a better way (now there's a value for
TB recharge value instead of hardcoded "recharge fully")

Istrebitel added a commit that referenced this pull request Sep 7, 2017

Attempt to fix mem leaks in battle #1
- added more cleanup of BattleUnit and Agent references

Istrebitel added a commit that referenced this pull request Sep 7, 2017

Istrebitel added a commit that referenced this pull request Sep 7, 2017

Agent Inventory Fixes #1
- implemented lists having 1hover and select images instead of rectangle
frames
- can't open inventory if no agent selected in battlescape
- proper pickup cost in TB battlescape
- proper selection brackets for agent inventory
- agent stats properly display TUs in TB
- agent stats properly update TUs in TB
- agent stats properly update speed when moving items
- proper display and handling for armor (body armor overlapping slot for
hand)
- removed ability to equip armor into nonmatching armor slot
- implemented inventory pages
- skirmish provides all usable equipment to player
- implemented inventory in prestart screen
- removed error when cannot fit everything in alien inventory
- no battlescape updates when destroying battle causes tileobjects to
remove themselves
- fixed left and right armor hands having mismatching images on
paperdoll

JonnyH pushed a commit that referenced this pull request Sep 13, 2017

fire tracking ahead of target's movement, base defense begin #1
- projectiles lead target according to speed and distance
- proper cityscape projectiles ttl
- proper inventory screen for MCed enemies
- sucker jumps to where target is running
- base defense progress

Istrebitel added a commit that referenced this pull request Sep 25, 2017

Istrebitel added a commit that referenced this pull request Sep 30, 2017

Istrebitel added a commit that referenced this pull request Sep 30, 2017

generate agents/vehicles/etc controls in 1 place #1
- progress on moving generation of all controls into once place

Istrebitel added a commit that referenced this pull request Oct 9, 2017

progress checkin #1
- agent pathfinding now uses subway and tube, does not fiddle with
buildings anymore
- progress on openapoc settings, cargo and agent ferrying
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment